Add MINGW CI#44
Open
scribam wants to merge 2 commits intolibusb:mainfrom
Open
Conversation
Contributor
Author
|
macOS job from CI need to be rerun |
Youw
reviewed
May 9, 2026
Comment on lines
-70
to
-71
| - name: Install dependencies | ||
| run: brew install ninja |
Member
There was a problem hiding this comment.
the build does require ninja, why omit explicit install?
Contributor
Author
There was a problem hiding this comment.
macOS has ninja already installed and displays a warning in CI summary with the explicit install:
I don't mind dropping this change if you want to
Member
There was a problem hiding this comment.
Better to drop this as github runner may keep changing. The warning is okay.
Member
|
Yeah, current libusb multithreading stress test is known to be faulty. Restart sometime helps, but I ususally ignore if it fails, until it is unown to be fixed in the upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.